Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to install 3rd-party packages #12

Closed
deathaxe opened this issue Jun 6, 2022 · 3 comments · Fixed by #16
Closed

Add support to install 3rd-party packages #12

deathaxe opened this issue Jun 6, 2022 · 3 comments · Fixed by #16
Labels
enhancement New feature or request
Milestone

Comments

@deathaxe
Copy link
Member

deathaxe commented Jun 6, 2022

Relational

In case a syntax embeds a 3rd-party syntax it might be required to install it to succeed related syntax tests.

Request

Add a variable like packages to pass a list of repositories to clone packages from.

    steps:
      - uses: actions/checkout@v2
      - uses: SublimeText/syntax-test-action@v2
        with:
          build: ${{ matrix.build }}
          default_packages: ${{ matrix.default_packages }}
          packages:
            - https://github.com/danro/LESS-sublime
            - https://github.com/braver/SublimeSass
            - ...
@michaelblyons
Copy link

Might require giving the packages specific names, too, yes?

@FichteFoll FichteFoll added the enhancement New feature or request label Jun 12, 2022
@FichteFoll
Copy link
Member

FichteFoll commented Jun 12, 2022

It will require the repo and optionally a ref and the name to install at, but quite possible indeed.

(I wonder at what point I will change the wrapper script to use Python.)

@FichteFoll
Copy link
Member

This is now live in 2.2 after some fixes (via trial and error and an added test case in this repo).

@FichteFoll FichteFoll added this to the v2.2 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants