Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModButtonOption does not have a tooltip #387

Closed
tinyhoot opened this issue Jun 2, 2023 · 2 comments · Fixed by #389
Closed

ModButtonOption does not have a tooltip #387

tinyhoot opened this issue Jun 2, 2023 · 2 comments · Fixed by #389

Comments

@tinyhoot
Copy link
Contributor

tinyhoot commented Jun 2, 2023

Describe the bug
When trying to create a ModButtonOption without the attribute-based system it is impossible to create a tooltip for the button. It seems that ModButtonOption.cs is the only ModOptions class without a Tooltip field and a tooltip argument is also missing from its ModButtonOption.Create() method, which is inconsistent with every other ModOption.

To Reproduce
Steps to reproduce the behavior:

  1. Go to IDE
  2. Try to use ModButtonOption.Create() with tooltip = "my cool tooltip"
  3. Get yelled at by the compiler

Expected behavior
Being able to add a tooltip to a button just like any other option.

@LeeTwentyThree
Copy link
Member

It appears that there is no way to add tooltips for buttons in the base game, as opposed to the other options.

@JKohlman
Copy link
Contributor

JKohlman commented Jun 2, 2023

Neither did the color picker iirc so it should be easy enough to add templated on that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants