Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelable #34

Closed
Monabr opened this issue Dec 10, 2020 · 3 comments
Closed

Cancelable #34

Monabr opened this issue Dec 10, 2020 · 3 comments

Comments

@Monabr
Copy link

Monabr commented Dec 10, 2020

I think setCancelable is missing some logic. In my opinions it should works (or have logic) like button "later"
@SuddenH4X
Copy link
Owner

Hi @Monabr,

I think you're right! I will look into that and probably release an update next week. Thanks!

@Monabr
Copy link
Author

Monabr commented Jan 10, 2021

Thank you! I will look forward to it!

@SuddenH4X
Copy link
Owner

SuddenH4X commented Jan 17, 2021 •
edited
Loading

I fixed it on branch fix_cancelable_34 if you want to check it out. I also added an additional listener (dialogCancelListener) which could be useful too. I'm planning to release a new version with this and other fixes/updates next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SuddenH4X @Monabr