Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Annoucing to Teams to a different action #21

Open
BryceStevenWilley opened this issue Jan 12, 2024 · 0 comments
Open

Split Annoucing to Teams to a different action #21

BryceStevenWilley opened this issue Jan 12, 2024 · 0 comments

Comments

@BryceStevenWilley
Copy link
Contributor

https://docs.pypi.org/trusted-publishers/ is a thing, and is pretty nice; it lets you set some configs through your Pypi account, and then you don't have to have API keys for projects, Pypi will do secure key exchange between just that GitHub workflow, with a time limited key. Very cool.

However, our publish action does a little but more than just publishing; we check that the version number in the package matches the tag we just pushed, and we send an announcement to teams after publishing. The former is only a few lines, but the latter is very long. If we want to use trusted publishers, we should split out the teams announcement into it's own action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant