Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible refactor: merge getOptions into getPossibleTableRowMatches #617

Closed
plocket opened this issue Sep 18, 2022 · 0 comments
Closed

Possible refactor: merge getOptions into getPossibleTableRowMatches #617

plocket opened this issue Sep 18, 2022 · 0 comments
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.

Comments

@plocket
Copy link
Collaborator

plocket commented Sep 18, 2022

Is it useful to keep the abstraction or better to combine them?

getPossibleTableRowMatches is called only a few lines after getOptions, so they're very closely tied together anyway.

[We] could remove getOptions; it's only used in one place, and the one calling function, getAllFields, already has a lot of other implementation details for other types of fields, like checkboxes, so there's not a lot of benefit of abstracting getOptions out.

Originally posted by @BryceStevenWilley in #581 (comment)
@plocket plocket added enhancement New feature or request reopen We won't be taking care of this any time soon. labels Oct 1, 2024
@plocket plocket closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@plocket