-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub server: improve security of sensitive information #819
Comments
[This way doesn't work at all (not sure why or what it's actually supposed to do), but we found a different method of outputting bash commands to
name: Hide logs example
on: [push]
jobs:
hide-logs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Generate unique token
id: generate-token
run: echo "::set-output name=token::$(openssl rand -hex 20)"
- name: Stop processing commands
if: ${{ env.HIDE_LOGS == 'true' }}
run: echo "::stop-commands::${{ steps.generate-token.outputs.token }}"
- name: Run step with hidden logs
run: echo "This step's logs will not be shown."
- name: Resume processing commands
run: echo "::${{ steps.generate-token.outputs.token }}::" The token should be a unique string each time. I'm not sure phind is correct about being able to run it between steps. It might be necessary to run it in the same bash |
Right now the PR does log the config because that's a GitHub secret. If we revisit in future, here's probably a way to hide the config in the |
We won't print any sensitive info, but we don't know what docassemble will print in its logs.
echo
that that artifacts are turned off and how to turn them on.echo
how they can turn those logs on.Edit:
Docs: because your config is a github secret, you won't be able to see it's value at all as GitHub will replace it with "***" even if you choose to show the logs. We'd need to implement this:
You can use an action "variable" for your organization or your repository if you don't want the config to be hidden by github.Maybe a question for a new issue: Instead of making an artifact, return the text of the docker log as an output? Still, avoid doing it by default, at least before turning off the logs, as that will show it in the console - whenever any bash command is run, all the output values are shown as env vars for some reason. I am concerned, though, that this output will show in the dev's own code unintentionally.
The text was updated successfully, but these errors were encountered: