Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for incorrect use of ' or " when users look for a phrase on the page #951

Open
plocket opened this issue Oct 22, 2024 · 0 comments
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.

Comments

@plocket
Copy link
Collaborator

plocket commented Oct 22, 2024

This is regarding the "phrase" Step.

Docassemble renders the page with special characters. Relevant to this issue, it shows left quote and right quote even when the code for the page only has ' (see the docs about special characters). Authors sometimes accidentally put the character from their code into the tests, e.g. ' instead of left quote. We can probably handle that:

When parsing the Step arguments, replace all ', ", and special quote characters with something weird, like !!@. Do the same when parsing the text on the page. Then try to match that text. If we need to print the mismatch, print the originals, of course.

@plocket plocket added enhancement New feature or request reopen We won't be taking care of this any time soon. labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reopen We won't be taking care of this any time soon.
Projects
None yet
Development

No branches or pull requests

1 participant