Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup: Add automated tests and then test setup interview #148

Open
32 tasks
plocket opened this issue Jul 17, 2021 · 0 comments
Open
32 tasks

Setup: Add automated tests and then test setup interview #148

plocket opened this issue Jul 17, 2021 · 0 comments
Labels
help wanted Extra attention is needed setup Related to the test setup interview

Comments

@plocket
Copy link
Collaborator

plocket commented Jul 17, 2021

[After #147.] May break this out into separate issues. [Also, this is complicated by the fact that it creates pull requests and secrets and we somehow need to detect that and possibly delete those to clean up.]

Org/repo type

  • Public org
  • Public repo
  • Private org
  • Private repo

happy paths (and role/goal combos):

  • is org_admin (admin permissions)
    • org secret
    • org secret + repo files
    • repo secret
    • repo secret + repo files
    • repo files (skips pages about being logging onto test account)
  • is not org_admin (repo admin, maintain, and write permissions)
    • repo secret
    • repo secret + repo files
    • repo files (skips pages about being logged onto test account)

Should we also repeat tests on (when appropriate) org-owned repo vs. account owned repo?

Can't continue:

  • goals page:
    • don't select any goals
    • wants to set up test files, but not have secrets
  • All other pages all fields are required, so don't need testing

Different text/fields shown depending on choices:

Too many of these for my brain right now

Invalid input feedback error pages:

  • da_url_error (set up tests)
    • invalid server part of url
    • invalid playground id
    • different url ends - extra args, page nums, just the plain url, only up till id
  • github_token_error (all)
    • token is not associated with any account, basically
  • github_pat_scopes_error (all)
    • not admin:org when want to set org secrets
    • not all scopes when want to set org secrets and add test files
    • not workflow and repo when want repo secret
    • not workflow and repo when want set up test
  • github_repo_not_found_error (repo secrets, set up tests)
    • repo doesn't exist
  • github_url_error (repo secrets, set up tests) (not sure how to test. partial url?)
    • does not have repo name
    • does not have owner name
  • not_collaborator_error (repo secrets, set up tests)
    • not a collaborator
    • (TODO: not has write permissions)
  • org_does_not_exist_error (org secrets)
    • owner name is not an org in github
  • not_an_org_member_error (org secrets)
    • token user is not a member of org
  • not_org_admin_error (org secrets)
    • token user is not an admin of org
  • github_branch_name_error (all)
    • 21st branch name (then delete all branches, please. Dang. We should have one repo that is just for this already prepped with those branches.)
  • permissions_error (all)
    • is 'read' or 'triage' permissions
@plocket plocket added help wanted Extra attention is needed setup Related to the test setup interview labels Jul 17, 2021
@plocket plocket changed the title Setup: Add test for setup interview Setup: Add automated tests and then test setup interview Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed setup Related to the test setup interview
Projects
None yet
Development

No branches or pull requests

1 participant