Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical multiselect - top level topics aren't clickable, only the expand/collapse triangle #182

Open
nonprofittechy opened this issue Jun 1, 2023 · 6 comments
Labels
accessibility ui User interface / design stuff, usually CSS

Comments

@nonprofittechy
Copy link
Member

We should probably fork the upstream package and come up with a better build process so we can make continual improvements. Right now we just have a minified and compiled JS + CSS file.

There are 2 thousand forks of https://github.com/davidstutz/bootstrap-multiselect. Perhaps one of those already does what we need.

@BryceStevenWilley
Copy link
Contributor

There are 2 thousand forks of https://github.com/davidstutz/bootstrap-multiselect. Perhaps one of those already does what we need.

There are about 28 forks that have any push activity (i.e. were ever changed) and were updated in the past 2 years.

@nonprofittechy
Copy link
Member Author

nonprofittechy commented Jun 1, 2023

Here are two alternatives, neither of which have collapsible option groups, but they do appear to be more up to date:

@plocket
Copy link
Collaborator

plocket commented Jun 12, 2023

I think it's worth looking at both to see how complex they would be to adjust. Maybe an update to v5 would be enough for the first option and then we can then just improve styles with CSS, but maybe not.

Either way, during deep dive we discussed forking whatever our choice turns out to be as neither repo has been updated in a while anyway and both have lots of PRs pending.

@BryceStevenWilley
Copy link
Contributor

Looked at these pretty quickly, both aren't great at screen reader and keyboard control accessibility, but snapappointments was better, and there is a PR that might improve accessibility there.

neither repo has been updated in a while anyway and both have lots of PRs pending.

davidstutz is actively looking for a new maintainer, for what it's worth.

@plocket
Copy link
Collaborator

plocket commented Jun 25, 2023

snapappointments

We may have to fork this one too. It looks great, but at least one of the issues is about needing to update to the newer version of bootstrap.

@nonprofittechy
Copy link
Member Author

Decision:

  • Stick with the current plugin
  • Use a copy of the source in the ALToolbox somewhere at an appropriate place
  • Edit the source to fix the issues we’ve identified
  • Document how to do the build step but it doesn't necessarily need to be automated
  • Do a more comprehensive accessibility audit of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility ui User interface / design stuff, usually CSS
Projects
None yet
Development

No branches or pull requests

3 participants