feat(helm): use configmap to configure tailing-sidecar-operator #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
commented
May 30, 2023
sumo-drosiek
commented
May 30, 2023
sumo-drosiek
commented
May 30, 2023
sumo-drosiek
commented
May 30, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-use-exposed-configuration
branch
from
0c96123 to
86678a4
Compare
swiatekm
approved these changes
May 30, 2023
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use configmap in helm chart to provide configuration for sidecar operator.
This is another step for #467
The last step will be adding
customConfigmap(content or name), which will be injected into sidecar, which is going to allow to override fluent-bit configuration