Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu.mem.info() totalMemMb is actually MiB #14

Open
connerdassen opened this issue Dec 17, 2020 · 3 comments
Open

osu.mem.info() totalMemMb is actually MiB #14

connerdassen opened this issue Dec 17, 2020 · 3 comments

Comments

@connerdassen
Copy link

The function from the title is called .totalMemMb, which suggests a return value in megabit.
I found the actual return value to be in MiB, (mebibytes)
(Mb = megabit, MB = megabyte, MiB = mebibyte, there's a difference!)

Therefore I think the function name should be changed to .totalMemMib.

@SunilWang
Copy link
Owner

SunilWang commented Dec 18, 2020

@kontenbonker

The difference is small。
Although there are differences, I think you can ignore difference。
Do you think?

@connerdassen
Copy link
Author

connerdassen commented Dec 18, 2020

Actually, since Mb is megabit, the difference is quite a lot. On my server with 64GB ram, the return value of the function is 65365,1484375, which is the amount of MiB. If it were actually in Mb like the name suggests, the amount should be 574957,9260666838.
That's about 8.8 times more.

@SunilWang
Copy link
Owner

@kontenbonker
Can you provide the Mb algorithm, commit a Pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants