Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Simplify unit tests #8

Open
1 of 3 tasks
aburrell opened this issue Aug 26, 2020 · 6 comments
Open
1 of 3 tasks

TST: Simplify unit tests #8

aburrell opened this issue Aug 26, 2020 · 6 comments

Comments

@aburrell
Copy link
Collaborator

aburrell commented Aug 26, 2020

Simplify unit tests by:

  • using one unit test package (unittest, after some discussion with @mts299)
  • use subTest to reduce duplication in tests
  • use discover and remove main declaration on bottom of current tests
@aburrell aburrell mentioned this issue Aug 26, 2020
@aburrell aburrell changed the title Simplify unit tests TST: Simplify unit tests Aug 26, 2020
@aburrell aburrell self-assigned this Aug 26, 2020
@aburrell
Copy link
Collaborator Author

@mts299 would it be possible to create a data test directory in tests that holds the example files?

@aburrell
Copy link
Collaborator Author

aburrell commented Sep 18, 2020

Test files:

  • unit
    • test_borealis.py
    • test_conversions.py
    • test_dmap.py
    • test_superdarn.py
  • integration
    • test_borealis.py
    • test_dmap.py
    • test_superdarn.py

@mts299
Copy link
Collaborator

mts299 commented Sep 18, 2020

Probably is our data is large and if we cut things down we are still requiring the user to essentially install partial files which can still make the package large to install in python terms. Something @mardet987 noticed. I was thinking way back when we could DOI a data test file collection for DAWG software and then just have it curl it down and test via that way.

@aburrell
Copy link
Collaborator Author

I was thinking way back when we could DOI a data test file collection for DAWG software and then just have it curl it down and test via that way.

I'm good with that. Since I assume you have all of these files locally, can you or someone else in your group set it up? At the moment I can't test the changes I'm making locally, so could be introducing bugs.

@mts299
Copy link
Collaborator

mts299 commented Sep 18, 2020

Sounds good, but will need to do it next week and need to talk to Kathryn about it.

@aburrell
Copy link
Collaborator Author

Before you save these, can you run it by me? There's a directory structure I'd like to use so that the files can be updated or replaced without breaking the unit tests.

@aburrell aburrell mentioned this issue Oct 2, 2020
@aburrell aburrell removed their assignment Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants