You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We noticed that np.zeros in rtp.py line 344 is incorrectly formatted.
This line hasn't been changed in over 5 years so assuming the conditions that cause this to trigger are not done very often as we haven't had any complaints about it yet - to the point where we can't get it to to trigger a lot of the time.
I recommend checking all uses of np.zeros across pyDARN to check for this error as there are two instances in rtp.py where the line should read np.zeros([1, y_max]) instead of np.zeros(1, y_max).
I also recommend looking at refactoring this section of code to make it more obvious in what it's trying to do.
Priority
Minor - typo, incorrect naming, fails on specific uncommon situation
Major - misrepresentation of data, failure in a common situation
Urgent - failure in usage, large misrepresentation
The text was updated successfully, but these errors were encountered:
BUG
We noticed that np.zeros in rtp.py line 344 is incorrectly formatted.
This line hasn't been changed in over 5 years so assuming the conditions that cause this to trigger are not done very often as we haven't had any complaints about it yet - to the point where we can't get it to to trigger a lot of the time.
I recommend checking all uses of np.zeros across pyDARN to check for this error as there are two instances in rtp.py where the line should read
np.zeros([1, y_max])
instead ofnp.zeros(1, y_max)
.I also recommend looking at refactoring this section of code to make it more obvious in what it's trying to do.
Priority
The text was updated successfully, but these errors were encountered: