Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperPWA break batch plugins activation #93

Closed
ariona opened this issue Jan 23, 2019 · 8 comments
Closed

SuperPWA break batch plugins activation #93

ariona opened this issue Jan 23, 2019 · 8 comments
Labels
bug Something isn't working the way it was designed

Comments

@ariona
Copy link

ariona commented Jan 23, 2019

Hello, I am a theme developer and I included the SuperPWA in my required plugins using TGMPA. Installing the plugin is no problem, but when activating the plugins at the same time (batch action), the process stop on PWA with the error:

Fatal error: Uncaught Error: Class 'WP_Plugins_List_Table' not found in /Applications/MAMP/htdocs/wp-sandbox/wp-content/plugins/super-progressive-web-apps/admin/basic-setup.php:74 
Stack trace: 
#0 /Applications/MAMP/htdocs/wp-sandbox/wp-includes/class-wp-hook.php(286): superpwa_activation_redirect('super-progressi...', false) 
#1 /Applications/MAMP/htdocs/wp-sandbox/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters('', Array) 
#2 /Applications/MAMP/htdocs/wp-sandbox/wp-includes/plugin.php(453): WP_Hook->do_action(Array) 
#3 /Applications/MAMP/htdocs/wp-sandbox/wp-admin/includes/plugin.php(625): do_action('activated_plugi...', 'super-progressi...', false) 
#4 /Applications/MAMP/htdocs/wp-sandbox/wp-admin/includes/plugin.php(759): activate_plugin('super-progressi...', '', false, false) 
#5 /Applications/MAMP/htdocs/wp-sandbox/wp-content/themes/librarium/inc/TGMPA/class-tgm-plugin-activation.php(3025): activate_plugins(Array) 
#6 /Applications/MAMP/htdocs/wp-sandbox/wp-content/themes/librarium/inc/TGMPA/class-tgm-plugin-ac in /Applications/MAMP/htdocs/wp-sandbox/wp-content/plugins/super-progressive-web-apps/admin/basic-setup.php on line 74

I am not sure if this is caused by TGMPA or SuperPWA plugin, but i hope the log above can give you guy a hint.

thanks

@arunbasillal
Copy link
Contributor

Hello @ariona

Thanks for the report.

The class WP_Plugins_List_Table probably isn't loaded at the time.

I have added a check in 2.1 (next release) so that this doesn't happen - c70bfd9

That should take care of it :)

@arunbasillal arunbasillal added the bug Something isn't working the way it was designed label Jan 24, 2019
@madmath03
Copy link

Hello @arunbasillal,

I encountered the same issue and this blocks my batch installs.
When is the next release planned to be deployed ?

@arunbasillal
Copy link
Contributor

@madmath03 Planning it for the second week of March.

@madmath03
Copy link

It's been 2 months now... is the next release still coming ?

@madmath03
Copy link

@arunbasillal Is this plugin still maintained ??

@madmath03
Copy link

madmath03 commented Jan 3, 2020

@arunbasillal Is this plugin still maintained ??

Well, I guess not 😅

@bobmulder
Copy link

I see a new version was released but I guess it didn't solve this issue. Would like to get some response from the maintainers :)

@arunbasillal
Copy link
Contributor

This should be fixed in 2.1 - c70bfd9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way it was designed
Projects
None yet
Development

No branches or pull requests

4 participants