Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #226

Merged
merged 1 commit into from
Oct 24, 2021
Merged

Fix tests #226

merged 1 commit into from
Oct 24, 2021

Conversation

ntbm
Copy link
Contributor

@ntbm ntbm commented Oct 24, 2021

Tests where broken in multiple ways

  1. They did not override the right config property anymore
  2. The path of the files wasn't in an git-ignored directory so i moved it to build and introduced a constant
  3. For me macOS the gradle tests weren't running on the command line the change in gradle works fine
    Also added some documentation on how to actually run the test

@AriaMoradi AriaMoradi merged commit d129747 into Suwayomi:master Oct 24, 2021
ntbm added a commit to ntbm/Tachidesk-Server that referenced this pull request Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants