Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Gradle Configuration #478

Merged
merged 4 commits into from
Jan 7, 2023
Merged

Improve Gradle Configuration #478

merged 4 commits into from
Jan 7, 2023

Conversation

Syer10
Copy link
Collaborator

@Syer10 Syer10 commented Jan 7, 2023

  • Use Gradle Versions Catalog
  • Use type-safe project accessors
  • Tachiyomi 1.x was archived so removed the note about it in the gradle files

AriaMoradi
AriaMoradi reviewed Jan 7, 2023
View reviewed changes
Copy link
Member

@AriaMoradi AriaMoradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be hard to read

gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
Syer10 and others added 3 commits January 7, 2023 11:22
@Syer10 @AriaMoradi
Formatting fix
0043a4e 
Co-authored-by: Aria Moradi <aria.moradi007@gmail.com>
@Syer10 @AriaMoradi
Improve asm version lock description
c6980e0 
Co-authored-by: Aria Moradi <aria.moradi007@gmail.com>
@Syer10 @AriaMoradi
Improve image decoder description
c84df10 
Co-authored-by: Aria Moradi <aria.moradi007@gmail.com>
@Syer10
Copy link
Collaborator Author

Syer10 commented Jan 7, 2023

👍

@AriaMoradi AriaMoradi merged commit ee8ec46 into Suwayomi:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriaMoradi AriaMoradi AriaMoradi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syer10 @AriaMoradi