Download as CBZ #490
Merged
Download as CBZ #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akabhirav
commented
Feb 8, 2023
akabhirav
commented
Feb 8, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/chapter/ChapterForDownload.kt
Outdated
Show resolved
Hide resolved
Syer10
requested changes
Feb 8, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/ChapterFile.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/Chapter.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/chapter/ChapterForDownload.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/download/Downloader.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/download/Downloader.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/ChapterFile.kt
Outdated
Show resolved
Hide resolved
AriaMoradi
requested changes
Feb 8, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/ChapterFile.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/ChapterFile.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/chapter/ChapterForDownload.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/Chapter.kt
Outdated
Show resolved
Hide resolved
|
I'll consider this PR blocked until we have fixed the issues with separating cache and download dir. |
akabhirav
force-pushed
the
master
branch
3 times, most recently
from
175f867
to
cc1bdd6
Compare
|
why did you close this? |
akabhirav
changed the title
akabhirav
requested review from
AriaMoradi and
Syer10
and removed request for
AriaMoradi
Syer10
requested changes
Feb 12, 2023
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/download/ArchiveProvider.kt
Outdated
Show resolved
Hide resolved
akabhirav
requested review from
AriaMoradi and
Syer10
and removed request for
AriaMoradi
Syer10
approved these changes
Feb 12, 2023
|
Thanks for this and quite excited about it. I've upgraded to 0.700 and am using the bundled WebUI but for the life of me, I can't figure out how to use the "Download as CBZ" functionality. Any hints? |
in server.conf |
|
I am getting an error when this setting is activated whilst trying to download comics |
I can confirm the same here as well, please open a new issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
This PR enables downloading files as CBZ. This means that Chapters will be saved as CBZ files instead of images inside the chapter folder
This PR also fixes page index issue for certain providers