-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source filters, move search to SourceMangas #142
Conversation
much the same as the library version
should i combine search in to browse |
rather than using resetFilterValue and updateFilterValue i should probably use a useState spamming too many options in quick succession will break it, i should be able to fix if i move to useStates |
your commit naming is fun |
worked out the breaking that was happening in the last commit im probably using useState for more than is nessessary, only really needed to do triggerUpdate and Data
i never know what to actually call my commits, so they tend to get pretty random worked out the breaking that was happening in the last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a brief changes list from visual testing
- the looks need a change to become inline with rest of the design(steal design from Tachiyomi)
- move search to Appbar
- convert the filter button to a FAB (copying Tachiyomi, not sure which design is better?)
- don't perfom search at filter input changes, have a Apply/Submit button to reduce network calls, optimize filter update network calls
- when filter results are loading, MangaGrid shows "No Manga Was found", instead it should show a loading spinner
I'll do a code review when at least non-design issues are fixed.
i re-used the query querystring
implementation of the
/api/v1/source/{sourceId}/filters
endpointright side (mangadex, different per source):
groups appear on top of the filters:
something JUI already implemented