Verticall scroll navigation and fix #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ear on when to scroll to inital page
…nstead of whole pages, refactor code
|
Tested and it works great. But Shift+space should go to prev page (à la PgUp) right now the shift key is ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the scrolling behavior in
Continues verticalandWebtoonlayouts. Instead of going to "next page", when user taps / clicks / preses key the view now scrolls 95% of its height. This makes reading webtoons much better. This fixes #162.I have not done the complete "magic" behavior, as described in the issue. I think the "if page is visible, scroll to the top of it" (snapping) would be weird for webtoons. I tried it on some "same page size" manga and the experience is very dependant on screen size.
In future the behavior could be configurable so user can specify how much it should scroll and also if the scroll should be smooth or instant. We could also add option for the "snapping" behavior described above.
While doing this, I have refactored some behavior in both vertical and horizontal scrolling layouts and added fix for different issue. This also fixes #14. When view is scrolled all the way (either direction) the last page number is now sent as current.