Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing curly bracket gets cut off sometimes #119

Closed
Sv443 opened this issue Jul 4, 2020 · 3 comments
Closed

Trailing curly bracket gets cut off sometimes #119

Sv443 opened this issue Jul 4, 2020 · 3 comments
Assignees
@Sv443
Labels
bug Something isn't working
Milestone
2.2.0

Comments

@Sv443
Copy link
Member

Sv443 commented Jul 4, 2020 •
edited
Loading

Examples: #191, #199
@Sv443 Sv443 added the bug Something isn't working label Jul 4, 2020
@Sv443 Sv443 added this to the 2.2.0 milestone Jul 4, 2020
@Sv443 Sv443 self-assigned this Jul 4, 2020
@Sv443 Sv443 mentioned this issue Jul 4, 2020
Merged
27 tasks
@Sv443
Copy link
Member Author

Sv443 commented Jul 6, 2020 •
edited
Loading

Jokes contained weird ass unicode apostrophes which for some odd reason break the API. Hotfixed by replacing with ', but I'm gonna have to write some tests for it or do some validation on submission.

image

@Sv443 Sv443 mentioned this issue Jul 7, 2020
Closed
@Sv443
Copy link
Member Author

Sv443 commented Jul 7, 2020

Made a new issue for submission validation: #123

@Sv443
Copy link
Member Author

Sv443 commented Jul 12, 2020 •
edited
Loading

Turns out, the real issue was setting the response header Content-Length in the httpServer.pipeString() function to the length of characters instead of the number of octets (bytes) of the string.

@Sv443 Sv443 closed this as completed Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sv443 Sv443

Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
1 participant
@Sv443