Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with genius API hiding song language behind second API call #20

Open
Sv443 opened this issue Jul 29, 2023 · 0 comments · May be fixed by #25
Open

Deal with genius API hiding song language behind second API call #20

Sv443 opened this issue Jul 29, 2023 · 0 comments · May be fixed by #25
Assignees
@Sv443
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@Sv443
Copy link
Owner

Sv443 commented Jul 29, 2023 •
edited
Loading

For some reason the song language has been removed from /search?q and is now only available in /songs/$id
This has broken the ?preferLang param.
Possible solutions:

  • Offer extra endpoints for "simple" info and "advanced" info, with different rate limits (and double the latencies, oof)
  • Always make a second API call at the cost of latency (yuck eww disgusting)
  • idfk
@Sv443 Sv443 added the bug Something isn't working label Jul 29, 2023
@Sv443 Sv443 self-assigned this Jul 29, 2023
@Sv443 Sv443 added this to the 1.4.0 milestone Aug 23, 2023
@Sv443 Sv443 modified the milestones: 1.4.0, 2.0.0 Nov 24, 2024
@Sv443 Sv443 linked a pull request Nov 24, 2024 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sv443 Sv443

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Version 2.0.0 Sv443/geniURL
1 participant
@Sv443