Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

有关server部分优化的提议 #114

Closed
swpfY opened this issue Dec 31, 2023 · 6 comments
Closed

有关server部分优化的提议 #114

swpfY opened this issue Dec 31, 2023 · 6 comments
Assignees
@swpfY @Feudalman @SAKURA-CAT
Labels
🙋 help wanted Extra attention is needed
Milestone
V0.1.5

Comments

@swpfY
Copy link
Member

swpfY commented Dec 31, 2023 •
edited
Loading

  1. 引入SQLite数据库和ORM。由于涉及到项目信息的“增删查改”，将基础配置信息写入数据库然后操作会更方便一些，操作JSON文件比较麻烦而且没有关系映射。ORM库例如：Peewee、SQLAlchemy、Prisma（python版本不成熟，不推荐使用）
  2. 将路由集中，将 Handler 分散。目前是将路由和 Handler 部分写在一起的，由于Handler部分的代码过多，会对排查造成影响。
@swpfY swpfY added the 🙋 help wanted Extra attention is needed label Dec 31, 2023
@Zeyi-Lin
Copy link
Member

New perspective🤔

@SAKURA-CAT
Copy link
Contributor

SAKURA-CAT commented Dec 31, 2023 •
edited
Loading

1 与 #5 有所重复，并且我们确实正在思考相关优化，感谢提议！

@swpfY
Copy link
Member Author

swpfY commented Dec 31, 2023

1 与 #5 有所重复，并且我们确实正在思考相关优化，感谢提议！

第1点的提议主要是基本配置信息，将日志写入文件是没问题的

@SAKURA-CAT
Copy link
Contributor

至于 2 ，事实上在server.modules中存在相关解耦尝试，不过目前处于敏捷开发阶段，相关优化未来会提上日程

@SAKURA-CAT
Copy link
Contributor

1 与 #5 有所重复，并且我们确实正在思考相关优化，感谢提议！

第1点的提议主要是基本配置信息，将日志写入文件是没问题的

明白，在项目设计阶段我们主要考虑了tag的信息存储，其他部分确实没有过多考虑.

@SAKURA-CAT SAKURA-CAT added this to the v0.2.0 milestone Jan 1, 2024
@SAKURA-CAT SAKURA-CAT mentioned this issue Jan 3, 2024
Merged
@Zeyi-Lin Zeyi-Lin pinned this issue Jan 3, 2024
@Zeyi-Lin Zeyi-Lin changed the title 🌖 有关server部分优化的提议 有关server部分优化的提议 Jan 6, 2024
@Zeyi-Lin Zeyi-Lin unpinned this issue Jan 7, 2024
@SAKURA-CAT SAKURA-CAT modified the milestones: v0.2.0, V0.1.5 Jan 14, 2024
@SAKURA-CAT
Copy link
Contributor

closed by #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swpfY swpfY

@Feudalman Feudalman

@SAKURA-CAT SAKURA-CAT

Labels
🙋 help wanted Extra attention is needed
Projects
None yet
Milestone
V0.1.5
Development

No branches or pull requests
4 participants
@swpfY @Zeyi-Lin @Feudalman @SAKURA-CAT