Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExcelR Table Crashes in Shiny when Pressing Enter on Last Row #109

Open
millett-a opened this issue Feb 24, 2022 · 1 comment
Open

ExcelR Table Crashes in Shiny when Pressing Enter on Last Row #109

millett-a opened this issue Feb 24, 2022 · 1 comment
Labels
bug Something isn't working can't reproduce

Comments

@millett-a
Copy link

Describe the bug
When editing the table in a Shiny app, I noticed that the app will crash when you press 'enter' on the last row. I noticed that briefly it seems to try to add a new row onto the end of it. Looking at the logs, I see this error:

Warning: Error in if: missing value where TRUE/FALSE needed

The problem isn't just changing the last row. If you change the last row then click elsewhere, the table updates as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Set up an excel table in a Shiny app
  2. Select a value on the last row of the table
  3. Press Enter

Expected behavior
I don't know what the expected behavior should be, as in Excel it would move to the next (empty) row. I would maybe suggest that if you're on the last row in a Shiny app, and you hit enter, it would then go back to the top of the table?

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version 98.0.4758.102 (Official Build) (x86_64)
@Swechhya
Copy link
Owner

@millett-a Can you check if you can replicate the issue in the latest development version?

@Swechhya Swechhya added bug Something isn't working can't reproduce labels Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce
Projects
None yet
Development

No branches or pull requests

2 participants