Follow up on 4 smoke test 404s

[finestructure]

https://gitlab.com/finestructure/swiftpackageindex/-/jobs/593828863

• https://swiftpackageindex.com/ArtSabintsev/FontBlaster
• https://swiftpackageindex.com/ArtSabintsev/Freedom
• https://swiftpackageindex.com/ArtSabintsev/Guitar
• https://swiftpackageindex.com/ArtSabintsev/Zephyr

[finestructure]

Looking at Guitar, I see that we're parsing the package name for releases but it seems to be lacking a package name for the .branch("master") default branch revision in versions.

Something wrong with the package file perhaps? https://github.com/ArtSabintsev/Guitar/blob/master/Package.swift

Perhaps .iOS(.v9) is problematic?

import PackageDescription

let package = Package(
    name: "Guitar",
    products: [
        .library(name: "Guitar", targets: ["Guitar"]),
    ],
    targets: [
        .target(name: "Guitar", path: "Sources/"),
    ],
    platforms: [.iOS(.v9)],  
    swiftLanguageVersions: [.v5]   
)

[finestructure]

Unlikely, we're properly indexing https://swiftpackageindex.com/ArtSabintsev/Siren which has

    platforms: [.iOS(.v8)],  

[finestructure]

Oh, interesting!

/Users/sas/Projects/SPI-Server/SPI-checkouts/github.com-artsabintsev-guitar/Package.swift:13:5: error: argument 'platforms' must precede argument 'products'
    platforms: [.iOS(.v9)],  
~~~~^~~~~~~~~~~~~~~~~~~~~~"
Output: """ (id: Optional(66AE3416-2D24-4663-B9D1-ED85B9C8BAFC))

FYI @ArtSabintsev - your package Guitar - and likely the other three as well - seems to be failing indexing because of this.

The release tags are coming through but if you swap around those two parameters in your Package.swift file the packages should be coming through ok.

[ArtSabintsev]

hey, sorry, mind telling me what I need to do to fix this issue? Where does products go? Thank you for letting me know.

[ArtSabintsev]

Oh, interesting, platforms goes before products. Cool, will take care of this on my end and push.

[ArtSabintsev]

ok, I updated it for:

https://swiftpackageindex.com/ArtSabintsev/FontBlaster
https://swiftpackageindex.com/ArtSabintsev/Freedom
https://swiftpackageindex.com/ArtSabintsev/Guitar
https://swiftpackageindex.com/ArtSabintsev/Siren
https://swiftpackageindex.com/ArtSabintsev/Zephyr

[ArtSabintsev]

Assume version tags will be pushed in 5 minutes from this message, as I need to update it for CocoaPods as well.

[finestructure]

Hi @ArtSabintsev - no need to tag, the issue was actually with indexing the default branch.

It should correct itself within the couple of hours or so. Thanks for taking a look!

[ArtSabintsev]

Got it - tagging anyway since I made minor changes anyway! Mind pinging me once you know if the issue has resolved or if further tweaks are needed? Thanks!

[finestructure]

Definitely, thanks @ArtSabintsev !

[finestructure]

@ArtSabintsev Everything except Guitar has now recovered. I’ll have a look what’s going on with that one tomorrow.

[ArtSabintsev]

I figured it out - the manifest was missing the preceding period around the .tvOS(.v10) line.

[finestructure]

Ah excellent. It just occurred to me that you could also run swift package dump to verify it’s ok but too late :)

[ArtSabintsev]

I just ran swift dump-package and the JSON was spit out properly, so I think we're golden. I don't see any changes yet for that one library, but it's only been 2 hours.

[ArtSabintsev]

Ok, confirmed that it's working now. We're good to close this issue. Thanks again for letting me know!

This is an awesome idea - just wanted to say that as well.

[finestructure]

Great, thanks @ArtSabintsev !