fix: only add existing directories to PATH on windows #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevapple unit tests are failing, could be due to the API usage change and might require updating/creating some mocks. Please make the changes applicable. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 91.41% 91.00% -0.42%
==========================================
Files 30 30
Lines 897 900 +3
Branches 122 122
==========================================
- Hits 820 819 -1
- Misses 76 80 +4
Partials 1 1
☔ View full report in Codecov by Sentry. |
stevapple
force-pushed
the
exact-windows-path
branch
from
15fad68
to
dea26ee
Compare
stevapple
changed the title
stevapple
force-pushed
the
exact-windows-path
branch
from
dea26ee
to
3119bba
Compare
|
@soumyamahunt The tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.