Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to store info about cli version #1388

Open
jachro opened this issue Mar 17, 2023 · 0 comments
Open

Do we need to store info about cli version #1388

jachro opened this issue Mar 17, 2023 · 0 comments

Comments

@jachro
Copy link
Contributor

jachro commented Mar 17, 2023

Currently, the decision about kicking off Re-provisioning or not is made based on the compatibility.re-provisioning-needed flag in the config. While this is undoubtedly good, during the changes in the area we dropped a step which was persisting the current version of CLI (and schema version). Now, the version pair stored in the migrations DS in the TS holds values that were used during the last Re-provisioning process. While this is maybe not extremely bad it also causes a bit of confusion when looking at the TG logs as it says something like this:

TS_MIGRATION_REQUEST: re-provisioning triples Store on (2.3.0,10); expected [cli-version: 2.3.2, schema-version: 10, reProvisioningNeeded=false]

while we in fact the TS is not on 2.3.0 (it would be actually even saying it's on schema 9 if the v10 migration wouldn't change the value).
Long story short, it might be the time that in the presence of mentioned compatibility.re-provisioning-needed flag, storing the CLI version might be:

  1. either taken out completely
  2. or updated every time TG gets a different version of CLI, even if no re-provisioning was done.
    Option 1. sounds to me a bit better choice.
@jachro jachro converted this from a draft issue Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready
Development

No branches or pull requests

1 participant