Add tests for GVI-usage + IRS-usage

[tph-thuering]

As #56 is now implemented, write tests for it.

[tph-thuering]

• Implement changes in scenario converter 33_to_34

or

• make usage an optional parameter.

The following tests are failing currently and need updates:
10 - 2ITNs (Failed)
15 - IRS30 (Failed)
23 - Rach5IC (Failed)
26 - VecFullTest (Failed)

Update: These tests work now since 4ddba28

[tph-thuering]

Tests are not necessary to be changed, as they are optional now. see 4ddba28

[dhardy]

I thought the add tests title was more about testing the new functionality than fixing compatibility issues?

[tph-thuering]

@dhardy You think they are needed? At first I did make <usage> mandatory (XSD: "minOccurs=1"), but changed it to optional (in XSD-context: minOccurs=0), so existing tests don't need to be changed and v33 scenarios won't need to be translated for this specific element.

So I think changing the tests are now obsolete in this case (I even chose this title).

Do you think we should create additional tests specifically for GVI- and IRS-usage?

[dhardy]

Making them optional is a good idea; it'll save a bunch of complaints about my XML is broken!

In theory there should be tests for every feature, but to do this properly you need (a) to do a mini-experiment (probably at least pop 10000 and a few repetitions) to check the feature seems to behave in the right way, and (b) including the feature in some test scenario with a small pop size (new or existing) to test the feature doesn't get broken by future code changes. But for simple features I'm often lazy; it can be a lot of work.

[tph-thuering]

I know there are a few test experiments which have <usage>0.8</usage> for ITN. I trust this behaves correct already and IRS + GVI-usage elements behave the same as the code looks the same and scaling of intervention effects is at the same code location for IRS + GVI.