Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: img2img mask not working on images that arent 512x512 #543

Closed
1 task done
AdamNizol opened this issue Sep 2, 2022 · 3 comments
Closed
1 task done

[Bug]: img2img mask not working on images that arent 512x512 #543

AdamNizol opened this issue Sep 2, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@AdamNizol
Copy link

AdamNizol commented Sep 2, 2022

What happened?

When doing the inpainting on a wide image it's not properly masking it and instead seems to be taking the mask, squishing it into 512x512 and applying img2img to only a portion of the image based on the squished mask. I used a fish that I generated which is 832x448 and I used img2img on the fish but I can see in the results that the part replaced is incorrect and where the fin is painted isn't regenerating like it should be, but a section to the left of it which shaped like a squished version of the fin, is generating when it shouldnt. I cant see the underlying mask but it seems to not be working properly for non-square images and from what I can tell is being squished and positioned on the left

Version

0.0.1 (Default)

What browsers are you seeing the problem on?

Chrome

Where are you running the webui?

Windows

Custom settings

width: 832
height: 448
blur: 2
sample steps: 50

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AdamNizol AdamNizol added the bug Something isn't working label Sep 2, 2022
@gmaxwell
Copy link

gmaxwell commented Sep 3, 2022

Was just about to open a bug on the same thing. The mask appears to be ignored completely when my resolution (and input image) are 768x512, both in current master and at stable-diffusion c0c2a7c

@hlky hlky changed the title [Bug]: inpainting not working on images that arent 512x512 [Bug]: img2img mask not working on images that arent 512x512 Sep 3, 2022
@hlky
Copy link
Contributor

hlky commented Sep 3, 2022

Yes, non-square mask is not applied correctly. It has never been applied correctly, the image editor is extremely experimental has is only causing issues whereby people complain when things that could be done in an external tool (photoshop) aren't working in this project's extremely limited image editor, this project is not an image editor, it is a user interface for stable diffusion.
Please respect the limitations of the project, and refrain from complaining about issues that can be resolved simply by not expecting this webui to do them and using the appropriate tools.

@hlky hlky closed this as completed Sep 3, 2022
@AdamNizol
Copy link
Author

Yes, non-square mask is not applied correctly. It has never been applied correctly, the image editor is extremely experimental has is only causing issues whereby people complain when things that could be done in an external tool (photoshop) aren't working in this project's extremely limited image editor, this project is not an image editor, it is a user interface for stable diffusion. Please respect the limitations of the project, and refrain from complaining about issues that can be resolved simply by not expecting this webui to do them and using the appropriate tools.

I wasn't trying to complain, I just figured I would explain the bug I had in case you werent aware. I didn't realize that we could make the masks separately though. Do I need to enable something in the settings to allow me to upload the mask or something? I dont see the option or documentation for it which is why I assumed the UI worked. Ultimately uploading my own mask would be ideal anyway. Would white or black part be the part kept in a mask? Or do you just convert the opacity channel into the mask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants