Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: OrderPaymentLinkSender #158

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

igormukhingmailcom
Copy link
Contributor

Now created Order passed to email template to be able to render breakdown / user can see what he pays for

Now created `Order` passed to email template to be able to render breakdown / user can see what he pays for
@devfive
Copy link

devfive commented Jan 20, 2021

I think it should also pass localeCode like in other places, e.g. https://github.com/Sylius/Sylius/blob/f27be445c11eccd0556d5edbafd60067960ca46c/src/Sylius/Bundle/AdminBundle/EmailManager/OrderEmailManager.php#L32

but then it won't be only OrderPaymentLinkSender anymore, so this file should be renamed probably, what do you think?

@GSadee GSadee closed this Feb 25, 2022
@GSadee GSadee reopened this Feb 25, 2022
@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 25, 2022
@GSadee GSadee merged commit 2386921 into Sylius:master Feb 25, 2022
@GSadee
Copy link
Member

GSadee commented Feb 25, 2022

Thanks, Igor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants