Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Sylius 1.10 and Symfony >5.2 #170

Merged
merged 4 commits into from
Jul 29, 2021
Merged

Upgrade to Sylius 1.10 and Symfony >5.2 #170

merged 4 commits into from
Jul 29, 2021

Conversation

Roshyo
Copy link
Contributor

@Roshyo Roshyo commented Jul 14, 2021

Provide support for Sylius 1.10 and Symfony 5.2 or later

@Roshyo Roshyo requested a review from a team as a code owner July 14, 2021 08:49
@Zales0123 Zales0123 added the Maintenance Configurations, READMEs, releases, etc. label Jul 21, 2021
@Zales0123 Zales0123 closed this Jul 21, 2021
@Zales0123 Zales0123 reopened this Jul 21, 2021
@Zales0123 Zales0123 force-pushed the sylius-1.10 branch 2 times, most recently from 889ff30 to 7363af2 Compare July 21, 2021 09:10
@Zales0123
Copy link
Member

Hello @Roshyo! Even though we're not supporting this plugin actively nowadays, this PR is definitely something we would like to have :) I've enabled proper builds and made some changes in dependencies, but it requires a little bit of work to be mergeable. Do you think you would be able to fix it in the nearest future, or should I take it over?

Cheers 🖖

@Roshyo
Copy link
Contributor Author

Roshyo commented Jul 21, 2021

Well, since I will be away for the next 3 weeks or so. I would love it if you could take over on that point.

Or it will have to wait until I get back.

@Zales0123 Zales0123 force-pushed the sylius-1.10 branch 6 times, most recently from 27c9e91 to eb381cb Compare July 22, 2021 14:50
GSadee
GSadee reviewed Jul 23, 2021
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@GalloisLuca GalloisLuca mentioned this pull request Jul 23, 2021
Closed
pamil
pamil reviewed Jul 29, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@pamil pamil merged commit da331b2 into Sylius:master Jul 29, 2021
@pamil
Copy link
Contributor

pamil commented Jul 29, 2021

Thank you, Stephane! 🎉

@aleho
Copy link

aleho commented Jul 30, 2021

The release notes state "Upgrade to Sylius 1.10" but this PR did not bump the allowed Sylius version from 1.9.

This resluts in sylius/admin-order-creation-plugin v0.12.0 requires sylius/sylius 1.9.* -> found sylius/sylius[v1.9.0-RC.1, ..., v1.9.5] but it conflicts with your root composer.json require (1.10.*)..

Has this PR not been tested with Sylius 1.10 or is my composer.json wrong?

@pamil
Copy link
Contributor

pamil commented Jul 30, 2021

@aleho good catch, we've totally missed that!

@pamil pamil mentioned this pull request Jul 30, 2021
Merged
Zales0123 added a commit that referenced this pull request Jul 30, 2021
@Zales0123
bug #173 Really allow for Sylius 1.9 and 1.10 (pamil)
4beca13 
This PR was merged into the 1.1-dev branch.

Discussion
----------

As mentioned by @aleho in #170.

Commits
-------

c0ea107 Really allow for Sylius 1.9 and 1.10
@Roshyo Roshyo deleted the sylius-1.10 branch July 30, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Roshyo @Zales0123 @pamil @aleho @GSadee