Support Symfony 6 and Sylius 1.12 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMilek
force-pushed
the
support-symfony-6
branch
10 times, most recently
from
3ab8b1e
to
bb95762
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
from
bb95762
to
e1b54eb
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
3 times, most recently
from
ef086ad
to
732d3a2
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
from
732d3a2
to
d335e05
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
from
c75fc7e
to
d335e05
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
from
d335e05
to
5b1b162
Compare
TheMilek
force-pushed
the
support-symfony-6
branch
from
5b1b162
to
cec5f02
Compare
coldic3
reviewed
Dec 7, 2022
TheMilek
force-pushed
the
support-symfony-6
branch
from
548a2e6
to
49bef4e
Compare
coldic3
approved these changes
Dec 8, 2022
Rafikooo
approved these changes
Dec 9, 2022
GSadee
approved these changes
Dec 13, 2022
| @@ -20,11 +20,15 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| php: ["8.0", "8.1"] | |||
| symfony: ["^4.4", "^5.4"] | |||
There was a problem hiding this comment.
It would be nice to drop support for Symfony 4.4 in a separate PR
| @@ -29,6 +31,7 @@ public function buildForm(FormBuilderInterface $builder, array $options): void | |||
| ]); | |||
|
|
|||
| $builder->addEventListener(FormEvents::SUBMIT, function (FormEvent $event) use ($options): void { | |||
| /** @var Adjustment|null $adjustment */ | |||
|
Thank you, Kamil! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.