Save credit memos on server during generation #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jun 29, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.3 |
| Bug fix? | no |
| New feature? | yes |
| Related tickets | fixes #351 |
GSadee
force-pushed
the
save-credit-memos-on-server
branch
2 times, most recently
from
a363ad3 to
3c9e777
Compare
GSadee
force-pushed
the
save-credit-memos-on-server
branch
from
0f2a1a9 to
5e1260f
Compare
GSadee
changed the title
AdamKasp
approved these changes
Jul 1, 2022
coldic3
approved these changes
Jul 1, 2022
features/pdf_generation_enabled/saving_credit_memos_on_server_during_generation.feature
Show resolved
Hide resolved
Zales0123
reviewed
Jul 1, 2022
Comment on lines
79
to
91
| private function generatePdf(CreditMemoInterface $creditMemo): void | ||
| { | ||
| if (!$this->hasEnabledPdfFileGenerator) { | ||
| return; | ||
| } | ||
|
|
||
| if (null === $this->creditMemoPdfFileGenerator || null === $this->creditMemoFileManager) { | ||
| return; | ||
| } | ||
|
|
||
| $creditMemoPdf = $this->creditMemoPdfFileGenerator->generate($creditMemo->getId()); | ||
| $this->creditMemoFileManager->save($creditMemoPdf); | ||
| } |
There was a problem hiding this comment.
We're already injecting 3 new arguments into this service, also this method does not return anything and is quite independent. Maybe let's create a separate service for generating and saving pdf credit memos and inject it here? It would result in better encapsulation and having only one new argument injected here 🖖
There was a problem hiding this comment.
I've used here the created resolver, as it does what I need, but I have some doubts if this is a proper service, as its name could be misleading 🤔
GSadee
force-pushed
the
save-credit-memos-on-server
branch
3 times, most recently
from
3ab6208 to
53c32ef
Compare
GSadee
force-pushed
the
save-credit-memos-on-server
branch
from
53c32ef to
2549553
Compare
Zales0123
approved these changes
Jul 4, 2022
| /** @test */ | ||
| function it_creates_file_in_given_filesystem(): void | ||
| { | ||
| $creditMemoFileManager = $this->prepareCreditMemoFileManager(); |
There was a problem hiding this comment.
We could call this function in setUp method
|
|
||
| $this->assertEquals($creditMemoPdf, $file); | ||
|
|
||
| $this->clearTemporaryDirectory(); |
|
Thanks, Grzegorz! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.