Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: in PlacedOrder definition add number property #630

Merged
merged 1 commit into from
Feb 3, 2020
Merged

docs: in PlacedOrder definition add number property #630

merged 1 commit into from
Feb 3, 2020

Conversation

EmilMassey
Copy link

No description provided.

@EmilMassey EmilMassey requested a review from a team as a code owner January 31, 2020 14:28
mamazu
mamazu approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@mamazu mamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. Looks great.

@mamazu mamazu merged commit 61146a1 into Sylius:master Feb 3, 2020
@mamazu
Copy link
Member

mamazu commented Feb 3, 2020

Thank you, Emil! 🎉

@lchrusciel
Copy link
Contributor

Should we update the swagger file now then? It's on dev-master, so we need to keep the version in sync, I suppose

ref. https://github.com/Sylius/ShopApiPlugin/blob/master/doc/swagger.yml#L4

@mamazu
Copy link
Member

mamazu commented Feb 5, 2020

True. I will have an eye on that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilMassey @mamazu @lchrusciel