[Maintenance] Upgrade Recipes & Refine Project Structure #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
force-pushed
the
2.0-update-recipes
branch
2 times, most recently
from
98002bc to
1e82079
Compare
Rafikooo
force-pushed
the
2.0-update-recipes
branch
from
1e82079 to
596199a
Compare
Rafikooo
force-pushed
the
2.0-update-recipes
branch
from
596199a to
cae1597
Compare
Rafikooo
force-pushed
the
2.0-update-recipes
branch
from
cae1597 to
f021599
Compare
Rafikooo
changed the title
mpysiak
approved these changes
Sep 26, 2024
Rafikooo
commented
Sep 26, 2024
Comment on lines
+414
to
+416
| "assets/bootstrap.js", | ||
| "assets/controllers.json", | ||
| "assets/controllers/hello_controller.js" |
There was a problem hiding this comment.
I was unsure how to handle these files and decided to remove them, as the way we have configured our UI seems to follow a different architecture
Wojdylak
approved these changes
Sep 26, 2024
GSadee
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
I would be for removing this config as nyholm is a dev dependency and probably we should not force to have it in the config in the end application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refreshes the project structure by upgrading Symfony recipes, committing default bundle configurations, and removing obsolete code.
Key changes:
1. Dropped PHPSpec
2. Adjusted PHPStan and PHPUnit configurations
3. Updated third-party recipe configuration files to align with Sylius
4. Removed annotations
5. Moved the migrations directory
An example migration:
