Update php, nodejs and nginx in Dockerfile #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
approved these changes
Sep 3, 2021
lchrusciel
approved these changes
Sep 7, 2021
|
Thanks, Youri! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the default versions in the Dockerfile.
The composer dependencies listed by Sylius standard no longer support PHP 7.3 and the NodeJS + nginx versions are heavily outdated.
Upgrading NodeJS even further can be done, but requires a lot more work as the front end dependencies are also pretty outdated. So I'd suggest doing it in a separate PR or development cycle.
Please don't just tag this and leave it hanging, currently the Docker setup is unusable because of this.
Perhaps we should add a step to the github actions workflow to check and confirm that the container images can actually be built, or even better build them and use them in the workflow. What do you think about that?