Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Bring back schema validate #658

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

lchrusciel
Copy link
Member

No description provided.

@lchrusciel lchrusciel requested a review from a team as a code owner January 18, 2022 08:25
@@ -156,6 +160,10 @@ jobs:
name: Run PHPStan
run: vendor/bin/phpstan analyse -c phpstan.neon -l max src/

-
name: Validate database schema
Copy link
Contributor

@vvasiloi vvasiloi Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe with this occasion move it right after "Prepare test application database", where it should've been in the first place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, the PR will be green after the next v1.11 release

@lchrusciel lchrusciel closed this Jan 25, 2022
@lchrusciel lchrusciel reopened this Jan 25, 2022
@Zales0123 Zales0123 merged commit 81df736 into Sylius:master Jan 25, 2022
@lchrusciel lchrusciel deleted the bring-sync branch January 25, 2022 09:32
@Zales0123
Copy link
Member

Thank you, Łukasz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants