[README] Add reasonable defaults configs for mailing and messenger to avoid production errors #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
approved these changes
Apr 6, 2022
GSadee
approved these changes
Apr 7, 2022
Roshyo
approved these changes
Apr 7, 2022
|
But doesn't the messenger part require a command line to install and configure DB tables ? |
|
@Roshyo we are fine. It may be done by command line, but Symfony messenger will take care of it during initialization |
Zales0123
approved these changes
Apr 13, 2022
… avoid production errors
Zales0123
force-pushed
the
reasonable-defaults
branch
from
cf9d09f to
03b08d8
Compare
|
Thank you, Łukasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mailing config results in 500 errors - this is the result that we can be sure of. So, it is better to turn it off by default, in my humble opinion. People who need mailing will adjust it anyway. The rest won't have a broken website.
The second config is quite similar. This is our recommendation, so it is reasonable to have it there.