Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker]Force no-interaction mode on installation #702

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Apr 14, 2022

During an installation the composer asks for plugins (https://getcomposer.org/doc/06-config.md#allow-plugins) that leads to failing Docker build and making the terminal interactive.

How to reproduce the problem? Create a project from current Sylius-Standard and try to run docker compose up -d

@Ferror Ferror requested a review from a team as a code owner April 14, 2022 10:57
@Ferror Ferror force-pushed the docker-old-minor branch from ec0bace to d57bc7e Compare April 14, 2022 11:05
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we have to sort out allow plugins quite fast for the main installation anyway

@lchrusciel lchrusciel added Bug Docker Docker-related issues and PRs. labels Apr 14, 2022
@lchrusciel
Copy link
Member

@Ferror are you doing all these changes on the master branch?

@lchrusciel lchrusciel merged commit f496b22 into Sylius:master Apr 14, 2022
@lchrusciel
Copy link
Member

Thank you, Zbigniew! 🎉

@Ferror
Copy link
Contributor Author

Ferror commented Apr 14, 2022

@Ferror are you doing all these changes on the master branch?

Yup.

@Ferror Ferror deleted the docker-old-minor branch April 14, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Docker Docker-related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants