[docker]Use mysql instead of percona #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
reviewed
May 6, 2022
| @@ -20,7 +20,7 @@ services: | |||
|
|
|||
| mysql: | |||
| # in production, we may want to use a managed database service | |||
| image: percona:5.7 | |||
| image: mysql:5.7 # Sylius is fully working on mysql 8.0 version | |||
There was a problem hiding this comment.
Why didn't you change the version to 8.0?
There was a problem hiding this comment.
There is no reason. We support both versions, but which is preferable for us - I don't know.
I can create additional PR with the version change, as the goal of PR was to clarify the db engine. Comment was extra 😄
lchrusciel
approved these changes
May 12, 2022
|
Thanks, Zbigniew! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Percona was introduced in the docker-compose in 2018, but we officially do not support this database provider (even if it is MySQL-based db engine)