Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker]Use mlocati/php-extension-installer to simplify Dockerfile #746

Merged
merged 1 commit into from
May 26, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented May 24, 2022

The https://github.com/mlocati/docker-php-extension-installer is highly popular in the docker and PHP community because it does one very good thing - simplify the installation of PHP extensions and their dependencies.

Should we at Sylius care about what alpine package install to have PDO extensions enabled? In my opinion no.

@Ferror Ferror requested a review from a team as a code owner May 24, 2022 08:20
@lchrusciel lchrusciel merged commit 14d6d7a into Sylius:master May 26, 2022
@lchrusciel lchrusciel added the Docker Docker-related issues and PRs. label May 26, 2022
@Ferror Ferror deleted the docker-mlocati-extensions branch June 29, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Docker-related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants