Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend]Run watch tasks in series instead of parallel #817

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Aug 24, 2022

I know there are probably not many people that use a gulp watch when working with Sylius Frontend. This PR will fix the development NODE container error:

[gulp-chug] (vendor/sylius/sylius/src/Sylius/Bundle/ShopBundle/gulpfile.babel.js) Error: listen EADDRINUSE: address already in use :::35729
    at Server.setupListenHandle [as _listen2] (net.js:1331:16)
    at listenInCluster (net.js:1379:12)
    at Server.listen (net.js:1465:7)
    at Server.listen (/srv/sylius/node_modules/tiny-lr/src/server.js:264:19)
    at Function.exports.listen (/srv/sylius/node_modules/gulp-livereload/index.js:97:18)
    at watchShop (/srv/sylius/vendor/sylius/sylius/src/Sylius/Bundle/ShopBundle/gulpfile.babel.js:242:14)
    at bound (domain.js:421:15)
    at runBound (domain.js:432:12)
    at asyncRunner (/srv/sylius/node_modules/async-done/index.js:55:18)
    at processTicksAndRejections (internal/process/task_queues.js:77:11)

The error occurs because each of the watch tasks creates its own server.

@Ferror Ferror requested a review from a team as a code owner August 24, 2022 20:20
@lchrusciel lchrusciel merged commit b908ddf into Sylius:1.12 Sep 13, 2022
@Ferror Ferror deleted the gulp-series branch September 15, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants