Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's use symfony/runtime #843

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Oct 13, 2022

I would like to propose using symfony/runtime component that has multiple advantages.

  1. Simplifies the console and index entry points
  2. Enables the ability to use other runtimes... Like Swoole, Roadrunner etc. https://github.com/php-runtime

https://symfony.com/blog/new-in-symfony-5-3-runtime-component

@Ferror Ferror requested a review from a team as a code owner October 13, 2022 18:34
@lchrusciel lchrusciel merged commit 20454ea into Sylius:1.12 Nov 1, 2022
@lchrusciel
Copy link
Member

Can we migrate https://github.com/Sylius/Sylius as well? Plus, publish some blogpost with recommendations to upgrade?

@Ferror Ferror deleted the symfony-runtime branch November 1, 2022 13:46
@lecajer
Copy link

lecajer commented Nov 2, 2022

Hi, how do you install Symfony Runtime in an existing project ?

I keep getting this error:

Fatal error: Uncaught LogicException: Symfony Runtime is missing. Try running "composer require symfony/runtime"

I tryed with :

docker-compose up --build -V --force-recreate php

@lchrusciel
Copy link
Member

Hey Jeremie! You have to adjust a few things inside of your project:

  1. require runtime on your project

image

2. adjust `public/index.php` and `bin/console` as done here

@Ferror perhaps we should publish this somewhere on Sylius blog

@lecajer
Copy link

lecajer commented Nov 3, 2022

Thanks @lchrusciel . I thought it was better to let the composer install in the Dockerfile do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants