Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maintenance] Use the when@environment to reduce amount of config files #845

Merged
merged 1 commit into from
Nov 10, 2022
Merged

[maintenance] Use the when@environment to reduce amount of config files #845

merged 1 commit into from
Nov 10, 2022

Conversation

Ferror
Copy link
Contributor

@Ferror Ferror commented Oct 13, 2022 •
edited
Loading

Let's use the power of Symfony configs and slim a little bit all of them :)

https://symfony.com/doc/5.4/configuration.html#configuration-environments

@Ferror Ferror requested a review from a team as a code owner October 13, 2022 18:53
@Ferror Ferror force-pushed the symfony-when-yaml branch 4 times, most recently from 9e815aa to b5467eb Compare November 1, 2022 23:26
@Ferror Ferror force-pushed the symfony-when-yaml branch from 6b90dee to d591532 Compare November 1, 2022 23:34
@TheMilek TheMilek merged commit 9cfa728 into Sylius:1.12 Nov 10, 2022
@TheMilek
Copy link
Member

Thanks, Zbigniew! 🎉

@Ferror Ferror deleted the symfony-when-yaml branch November 10, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

@TheMilek TheMilek TheMilek approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ferror @TheMilek @GSadee @jakubtobiasz