Replace Switfmailer with Symfony Mailer #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Switfmailer with Symfony Mailer fix build set mailer dsn
ernestWarwas
force-pushed
the
replace-swiftmailer
branch
from
578e378 to
ed552f9
Compare
Storage id changed to storage factory id test managing exchange rates test currency test test env
run exchange rates scenarios alone exclude echange rates scenarios
ernestWarwas
force-pushed
the
replace-swiftmailer
branch
from
aa701c2 to
255a81c
Compare
|
I'm not sure but your jwt keys should be renewed because you use another algorithm |
|
@vasilvestre Looks like it's not necessary 🎸 |
Nice ! :D |
Rafikooo
approved these changes
Oct 20, 2022
NoResponseMate
approved these changes
Oct 20, 2022
GSadee
approved these changes
Oct 21, 2022
|
|
||
| - | ||
| name: Run non-JS Behat (without managing catalog promotion scenarios and exchange rates) | ||
| run: vendor/bin/behat --colors --strict --no-interaction -vvv -f progress --tags="~@javascript&&~@todo&&~@cli&&@~managing_catalog_promotions&&@~managing_exchange_rates" |
There was a problem hiding this comment.
Suggested change
| run: vendor/bin/behat --colors --strict --no-interaction -vvv -f progress --tags="~@javascript&&~@todo&&~@cli&&@~managing_catalog_promotions&&@~managing_exchange_rates" | |
| run: vendor/bin/behat --colors --strict --no-interaction -vvv -f progress --tags="~@javascript&&~@todo&&~@cli&&~@managing_catalog_promotions&&~@managing_exchange_rates" |
There was a problem hiding this comment.
How is that releated to the replacement of SwiftMailer by SymfonyMailer ?
|
Thank you, Ernest! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.