Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADMIN] fix closed gateway config field in payment method form #11346

Merged
merged 1 commit into from
Apr 10, 2020
Merged

[ADMIN] fix closed gateway config field in payment method form #11346

merged 1 commit into from
Apr 10, 2020

Conversation

bigboss86
Copy link
Contributor

Q A
Branch? 1.6
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #11344
License MIT

@bigboss86 bigboss86 requested a review from a team as a code owner April 9, 2020 22:25
lchrusciel
lchrusciel approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Damian,

thanks for the contribution. It makes total sense. Congratulation for your first contribution to the core ;)

Next time, please add a screenshot of your UI fixes as well.

@lchrusciel lchrusciel merged commit 3e61a68 into Sylius:1.6 Apr 10, 2020
@lchrusciel
Copy link
Member

Thank you, Damian! 🎉

@bigboss86 bigboss86 deleted the fix-closed-gateway-config-field-in-payment-method-form branch April 10, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigboss86 @lchrusciel