-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Twig 2 support #924
Conversation
loic425
commented
Sep 5, 2024
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Related tickets | |
License | MIT |
"vimeo/psalm": "^5.20", | ||
"willdurand/hateoas-bundle": "^2.0" | ||
}, | ||
"conflict": { | ||
"friendsofsymfony/rest-bundle": "<3.0", | ||
"jms/serializer-bundle": "<3.5", | ||
"willdurand/hateoas-bundle": "<2.0 || ^2.6" | ||
"willdurand/hateoas-bundle": "<2.0 || ^2.6", | ||
"twig/twig": "<3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we have bumped up the dependency, I'm not sure if it is necessary to add this package additionally to the conflicts (and the about note to the CONFLICTS
file), do you see any benefit of that? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cause it's on require-dev, it needs a conflict. We often forgot about those conflicts when there are on "optional/dev" requirements.
However, I do not know if adding note in the conflict make sense, cause it's just a bumped dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed CONFLICTS file part.
857dcec
to
d0c0184
Compare
Thank you, Loïc! 🎉 |