Refreshed docs & readme #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszpietrzak1994
approved these changes
Feb 26, 2019
docs/configuration_sources.md
Outdated
| ``` | ||
|
|
||
| Like every other source, `filesystem` is disabled if not specified otherwise. To enable it and use | ||
| the default configuration, use the following configuration: |
There was a problem hiding this comment.
Does it mean that using the default filesystem configuration results in the configuration listed in a snippet above? If so, maybe it would be more coherent to mention it, i. e:
To enable it and use the default configuration (mentioned in the snippet above), use the following configuration.
docs/your_first_theme.md
Outdated
| @@ -0,0 +1,112 @@ | |||
| ## Your first theme | |||
|
|
|||
| This tutorial assumes that the [filesystem](configuration_sources.md#filesystem-configuration-source) source. | |||
There was a problem hiding this comment.
I think there's a verb missing somewhere in this sentence :D
pamil
force-pushed
the
1.3-docs-readme
branch
from
07aeb79 to
08a4442
Compare
|
Thanks, Kamil! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10, closes #8.