Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"mpv-version-error" is very misleading when entering incorrect player arguments #270

Closed
Gnuxie opened this issue Jan 18, 2020 · 3 comments
Closed

"mpv-version-error" is very misleading when entering incorrect player arguments #270

Gnuxie opened this issue Jan 18, 2020 · 3 comments
Labels
enhancement

Comments

@Gnuxie
Copy link

Gnuxie commented Jan 18, 2020

syncplay/syncplay/players/mpv.py

Line 101 in 4765fa4

self.quitReason = getMessage("mpv-version-error")

I've been fooled by this for a month thinking my distros mpv version was bad and actually i had just accidentally entered garbage into the player arguments.
@Et0h
Copy link
Contributor

Et0h commented Jan 27, 2020 •
edited
Loading

You're right, that is confusing. Thanks for reporting the issue and sorry about your wasted month!

@Et0h
Copy link
Contributor

Et0h commented May 16, 2020

I've hopefully resolved this issue with 5df3046.

@Gnuxie
Copy link
Author

Gnuxie commented May 21, 2020

I'd say so :)

@Gnuxie Gnuxie closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Et0h @Gnuxie