-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradient descent notebook #193
Comments
@KrisThielemans Which notebook are you referring to?
|
|
b6b0d6b edited the notebook a bit to warn people about the confusion on signs. |
@ckolbPTB should we move this notebook to |
@ckolbPTB what do you think about moving this to |
@evgueni-ovtchinnikov would you have time to change the sign here and adjust? |
currently the "ascent" is addressed by updating text in the notebook. This is good enough for 3.5. We'll multiply the PET objective function with -1 and descend in the next version |
Move now completed. The only thing remaining here is the strange line in the PET reconstructions. |
the PET recon has a funny line
Also, it is called gradient descent, but it is actually ascending due to some minus signs. Better to switch the sign in the PET, but keep it for MR and CT.
The text was updated successfully, but these errors were encountered: