Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to configure input files for Windows #128

Closed
KrisThielemans opened this issue Jun 29, 2018 · 9 comments · Fixed by #681
Closed

need to configure input files for Windows #128

KrisThielemans opened this issue Jun 29, 2018 · 9 comments · Fixed by #681
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

the Superbuild needs to create a powershell and bit file (when on Windows) like the current shell configuration files, based on following

$Env:Path += ";C:\Users\krisf\Documents\devel\build-VC\SIRF-SuperBuild-CMAKE3.11\INSTALL\bin"
 $Env:Path += ";C:\Users\krisf\Documents\devel\build-VC\SIRF-SuperBuild-CMAKE3.11\INSTALL\FFTW"
 $Env:Path += ";c:/Users/krisf/Documents/devel/boost_1_63_0/lib64-msvc-14.0/"
 $Env:PYTHONPATH = "C:\Users\krisf\Documents\devel\build-VC\SIRF-SuperBuild-CMAKE3.11\INSTALL\python"
 $Env:MATLABPATH = "C:\Users\krisf\Documents\devel\build-VC\SIRF-SuperBuild-CMAKE3.11\INSTALL\matlab"
 # need to be forward slashes 
 $Env:SIRF_PATH = "C:/Users/krisf/Documents/devel/build-VC/SIRF-SuperBuild-CMAKE3.11/sources/SIRF"
@evgueni-ovtchinnikov
Copy link
Contributor

I have cloned and built SIRF-SuperBuild (using CMake 3.10.0) on Windows 7 with Visual Studio 2013.

Had a problem with missing files debug.lib and optimized.lib. Figured out they are not actually needed - on the internet people suggest deleting them from the project, but it did not work for me as Build starts by running CMake, which creates them again – so tricked the Build by copying another .lib file and renaming the copy into debug.lib and another copy into optimized.lib.

This worked, and I set $Env:PYTHONPATH to new path in powershell, and was able to run PET tests.

Some progress then.

By the way, CMake left Python and Matlab destinations empty after Configure, so I set them manually – was it actually needed?

@KrisThielemans
Copy link
Member Author

great. I belief that the debug.log and optimized.lib are a VS 2013 issue. I certainly don't have it with 2015.

could you try the matlab side as well? Should work...

I'm also very interested in seeing if you can run the MR code (by usin gth eVM an dport forwarding of course). that's the bit that failed for me.

@evgueni-ovtchinnikov
Copy link
Contributor

python can run mr demos ok

matlab works for both pet and mr demos when started from windows; from git shell (with -nodesktop) it works too if i do not set $Env:MATLABPATH as you suggested, otherwise i get "Undefined function or variable 'matlabrc'", and mutilities library fails to load

@KrisThielemans
Copy link
Member Author

Excellent news!

From here it looks like we should add $matlabroot\toolbox\local (obviously with $matlabroot filled in). Can you try that?

This should be doable from CMake as we'll know what MATLABROOT is I believe.

@evgueni-ovtchinnikov
Copy link
Contributor

it works now!

@evgueni-ovtchinnikov
Copy link
Contributor

i mean it works now that i added $matlabroot\toolbox\local to $Env:MATLABPATH

@evgueni-ovtchinnikov evgueni-ovtchinnikov self-assigned this Oct 19, 2018
@KrisThielemans KrisThielemans modified the milestones: v2.0, v2.1 Feb 15, 2019
@KrisThielemans KrisThielemans modified the milestones: v2.1, v2.2 Oct 6, 2019
@KrisThielemans KrisThielemans modified the milestones: v3.2, v3.3 Jan 21, 2022
@KrisThielemans
Copy link
Member Author

Largely a duplicate of #460. @evgueni-ovtchinnikov is there anything here that needs to be handled?

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans nothing springs to mind at the moment

@KrisThielemans
Copy link
Member Author

closing as duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants